V5 migration of get-balance (native) and get-all-events api #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
reviewed
Dec 11, 2024
| const returnData = mapEventsV4ToV5( | ||
| await getContractEvents({ | ||
| contract: contract, | ||
| fromBlock: BigInt(fromBlock), |
There was a problem hiding this comment.
Typescript error here.
I think we should update the querystring schema here to be int | undefined only, and here use maybeBigInt(fromBlock) which maps a number | undefined type to bigint | undefined.
There was a problem hiding this comment.
fromBlock: maybeBigInt(fromBlock?.toString()) instead but keeping it unresolved to make sure its done correctly
nischitpra
force-pushed
the
np/balanceOfV5
branch
3 times, most recently
from
45b9d08 to
8dd2de0
Compare
arcoraven
approved these changes
Dec 12, 2024
* bump yarn to berry * fix all biome errors * bring back pinned resolved deps, fix whitepsace --------- Co-authored-by: Phillip Ho <[email protected]>
nischitpra
force-pushed
the
np/balanceOfV5
branch
from
686afe0 to
a7b8d01
Compare
auto-merge was automatically disabled
December 12, 2024 09:24
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests are created for compairing v4 and v5 outputs.
I'll need some basic help with Typescript types. I've only made jsdoc comments to explain the function parameters.
APIs migrated
PR-Codex overview
This PR primarily focuses on code quality improvements, including type adjustments, error handling enhancements, and updates to logging messages. It also includes some updates to dependencies and modifications to the way certain functions are structured.
Detailed summary
text=autoto.gitattributes._einstead ofein multiple files.typekeyword where applicable.unknowninstead ofany.package.jsonversion for@thirdweb-dev/engine.constinstead ofletwhere possible._reqinstead ofreqin various routes.testWebhookmethod inWebhooksService.